Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Advanced Spray more tolerable to use #34209

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make Advanced Spray more tolerable to use #34209

wants to merge 7 commits into from
+29 −5

Conversation

Terraspark4941
Copy link
Contributor

About the PR

Allows the Spray Nozzle to be inserted into the Backpack Water Tank, adds new icon sprite to indicate this too

Why / Balance

The spray nozzle cannot be stowed anywhere except in a backpack; guess what goes on your back while using the spray nozzle?

Media

image

Requirements

Changelog

🆑

  • tweak: The spray nozzle can now be stored inside the backpack water tank!

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jan 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025 •
edited
Loading

RSI Diff Bot; head commit c380948 merging into f0652d8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Back/Backpacks/waterbackpack.rsi

State Old New Status
icon Modified
icon-filled Added

Edit: diff updated after c380948

@Terraspark4941
Copy link
Contributor Author

Terraspark4941 commented Jan 4, 2025 •
edited
Loading

Some improvements could be made to this, but I do not have enough experience to implement them. Namely:

  • Radial menu on backpack to show Eject / Set Transfer Amount on Alt-click
    Nevermind the above, just getting the alt-click order resolved (eject, then set transfer amount) would mitigate this
  • Maybe a wielded sprite for the spray nozzle? The sprite's very obviously two-handed
  • Clothing sprites for the inserted variant of the backpack water tank

Someone else can try this themselves; this PR is ready to merge in my opinion

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Art Area: Art with no implications for other areas. A: Service Area: Service department, including cooking, botany, etc A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 4, 2025
@K-Dynamic
Copy link
Contributor

K-Dynamic commented Jan 5, 2025 •
edited
Loading

I personally think the portable tank backpack should print with the nozzle already inside

I would say also remove the nozzle recipe but there's a chance of losing the nozzle unless we tie the item's existence to the backpack somehow

@Terraspark4941
Copy link
Contributor Author

well, the monthly update cycle seems to have already gone through, so i could look into trying that

@Terraspark4941 Terraspark4941 marked this pull request as draft January 6, 2025 13:45
@Terraspark4941
Copy link
Contributor Author

neevermind i'm not built for that, will keep draft until i can fix the eject order and (maybe?) get a better icon sprite for the inserted nozzle

@K-Dynamic
Copy link
Contributor

neevermind i'm not built for that, will keep draft until i can fix the eject order and (maybe?) get a better icon sprite for the inserted nozzle

If it's outside your skill level then it's probably okay to go with the item slot approach, and just add a description to the bag that states it can hold nozzles.

@Terraspark4941 Terraspark4941 marked this pull request as ready for review January 15, 2025 13:49
@Terraspark4941
Copy link
Contributor Author

most BS merge conflict error i got holdon..

@Terraspark4941
Copy link
Contributor Author

Okay, final TODO checklist for the next person working on the Advanced Spray:

  • Add wielded sprites to spray nozzle
  • Add equipped sprites to backpack water tank w/ spray nozzle inserted
  • Make spray nozzle & backpack print together AND make them inseparable (think: hardsuit helmet style)

Beyond that, this PR is officially ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. A: General Interactions Area: General in-game interactions that don't relate to another area. A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Terraspark4941 @K-Dynamic @beck-thompson