Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync #2280

Merged
merged 75 commits into from
Jun 17, 2024
Merged

Upstream sync #2280

merged 75 commits into from
Jun 17, 2024

Conversation

Morb0
Copy link
Member

@Morb0 Morb0 commented Jun 17, 2024

Описание PR

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

nikthechampiongr and others added 30 commits June 15, 2024 04:25
* Fix incorrect usage of loc string

* Make it so you can no longer ahelp someone who is no longer selected
* CVarify meteor behavior

* Cache value to reduce CVar calls, hook into OnValueChanged

* _cfg is still null at construction time, fixed by just making it set up on Started instead

* Invoke immediately! Learning more every step of the way.

* Move cached value initialisation to Initialize call

* Add explicit supercall
…29024)

* Add a PointLight to firelocks when warnings are active

* Remove power requirement for lights
…on (#29037)

* make the donk microwave drop the correct board on normal deconstruction

* removed the unnecessary SyndicateMicrowaveMachineBoard tag
* Mannequin

* rsi license fix

* damage container fix

* container fix

hope this works

* layers fix + appearance comp (mb it help?)

* maybe fixed?

* one day it will work...

* can't even understand why test failing... (maybe fix?)

* last try?
The TEG used to limit hot-cold energy transfer based on actual power drawn, and had maximum efficiency at whatever temperature difference. This PR adjusts the hot-cold energy transfer to be uncapped, "venting" the excess heat that is not used to generate power, and adds an efficiency curve that limits efficiency at low thermal temperatures.

People have been cheesing the TEG by hooking up the hot end to the CO2 miner (which produces infinite, room-temperature gas) and the cold end to a space radiator.

With this change, you will actually need to set up a burn chamber in order to get appreciable power out of the TEG (see below).

If you build a gas holding chamber, you will have to throttle the gas flowing into the TEG instead of constantly cycling the gas through over and over again.
* hell 💀

* you're right

i'm dumb

* use the beautiful protoid and or in localization 🥩

* 🙏
* Update ClothingSystem.cs

* did it in a better way

* Update ClothingSystem.cs
* Adds New Shoes to Sec loadouts

* Remove Cowboy stuff from sec drobe(bye sheriff) + requested changed
* Remove Explosive Component from ClothingShoesBootsMagSyndie

* Makes BaseJetpack a parent of ClothingShoesBootsMagSyndie

* fix boots in hand looking like jetpack bug

* make syndicate magboots child of magboots
…chines: Fixes #28997 (#29071)

add CAPITALIZE()
PJBot and others added 16 commits June 16, 2024 23:25
…ream-sync

# Conflicts:
#	Resources/Prototypes/Entities/Objects/Specific/chemical-containers.yml
#	Resources/Prototypes/GameRules/events.yml
#	Resources/Prototypes/Loadouts/role_loadouts.yml
#	Resources/Textures/Mobs/Customization/reptilian_parts.rsi/meta.json
#	Resources/Textures/Structures/Power/apc.rsi/base.png
#	Resources/Textures/Structures/Power/apc.rsi/broken.png
#	Resources/Textures/Structures/Power/apc.rsi/channel0-auto_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel0-auto_on.png
#	Resources/Textures/Structures/Power/apc.rsi/channel0-manual_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel0-manual_on.png
#	Resources/Textures/Structures/Power/apc.rsi/channel1-auto_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel1-auto_on.png
#	Resources/Textures/Structures/Power/apc.rsi/channel1-manual_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel1-manual_on.png
#	Resources/Textures/Structures/Power/apc.rsi/channel2-auto_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel2-auto_on.png
#	Resources/Textures/Structures/Power/apc.rsi/channel2-manual_off.png
#	Resources/Textures/Structures/Power/apc.rsi/channel2-manual_on.png
#	Resources/Textures/Structures/Power/apc.rsi/display-charging.png
#	Resources/Textures/Structures/Power/apc.rsi/display-full.png
#	Resources/Textures/Structures/Power/apc.rsi/display-lack.png
#	Resources/Textures/Structures/Power/apc.rsi/display-remote.png
#	Resources/Textures/Structures/Power/apc.rsi/emag-unlit.png
#	Resources/Textures/Structures/Power/apc.rsi/frame.png
#	Resources/Textures/Structures/Power/apc.rsi/lock0-locked.png
#	Resources/Textures/Structures/Power/apc.rsi/lock0-unlocked.png
#	Resources/Textures/Structures/Power/apc.rsi/lock1-locked.png
#	Resources/Textures/Structures/Power/apc.rsi/lock1-unlocked.png
#	Resources/Textures/Structures/Power/apc.rsi/meta.json
#	Resources/Textures/Structures/Power/apc.rsi/panel.png
#	Resources/Textures/Structures/Power/apc.rsi/static.png
@Morb0 Morb0 requested a review from ficcialfaint as a code owner June 17, 2024 21:24
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Jun 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict PR have unsolved merge conflicts label Jun 17, 2024
# Conflicts:
#	Resources/Locale/ru-RU/borg/borg.ftl
#	Resources/Locale/ru-RU/guidebook/chemistry/effects.ftl
#	Resources/Locale/ru-RU/holiday/greet/holiday-greet.ftl
#	Resources/Locale/ru-RU/preferences/loadout-groups.ftl
#	Resources/Locale/ru-RU/station-events/events/meteor-swarm.ftl
@github-actions github-actions bot removed the Merge Conflict PR have unsolved merge conflicts label Jun 17, 2024
@Morb0 Morb0 merged commit 3f4849c into master Jun 17, 2024
12 of 14 checks passed
lzk228 pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.