Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bookworm and readme #242

Merged
merged 45 commits into from
Feb 14, 2024
Merged

Fix bookworm and readme #242

merged 45 commits into from
Feb 14, 2024

Conversation

bugoff
Copy link
Contributor

@bugoff bugoff commented Jan 24, 2024 •
edited by damacus
Loading

Description

Updated readme this cookbook only supports Chef 15.5+

Since Debian Bookworm the ntp user is ntpsec (i expect Debian will continue to use this in all later versions)

For Debian / redhat based os'es there is a leap-second file, prefer to use this.

Issues Resolved

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@bugoff bugoff requested a review from a team as a code owner January 24, 2024 22:04
damacus
damacus reviewed Feb 2, 2024
View reviewed changes
attributes/default.rb Outdated Show resolved Hide resolved
damacus
damacus requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! thank you

@bugoff bugoff marked this pull request as draft February 2, 2024 16:49
@bugoff bugoff force-pushed the fix_bookworm_read branch from 71261b9 to 8e4a906 Compare February 5, 2024 21:16
@bugoff bugoff force-pushed the fix_bookworm_read branch from 8e4a906 to 0683433 Compare February 5, 2024 21:26
@damacus damacus marked this pull request as ready for review February 13, 2024 12:48
@damacus damacus self-assigned this Feb 13, 2024
@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label Feb 13, 2024
damacus
damacus previously approved these changes Feb 13, 2024
View reviewed changes
damacus
damacus reviewed Feb 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
damacus
damacus reviewed Feb 13, 2024
View reviewed changes
kitchen.dokken.yml Outdated Show resolved Hide resolved
@damacus damacus self-requested a review February 13, 2024 12:55
damacus
damacus reviewed Feb 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@damacus damacus merged commit 4f3dfc5 into sous-chefs:main Feb 14, 2024
20 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 5.1.0

@damacus
Copy link
Member

damacus commented Feb 14, 2024

Thankas @bugoff! that's been released ❤️

This was referenced Feb 14, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damacus damacus damacus left review comments

Assignees

@damacus damacus

Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugoff @kitchen-porter @damacus