Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default leapseconds file to /usr/share/zoneinfo/leap-seconds.list on Debian platforms #217

Closed
hrak opened this issue Feb 16, 2023 · 3 comments

Comments

@hrak
Copy link
Contributor

hrak commented Feb 16, 2023

👻 Brief Description

This cookbook currently supplies its own (constantly expired) leapseconds file without a way of overriding the cookbook file in a wrapper cookbook. Debian based distro's already have an up-to-date file in /usr/share/zoneinfo/leap-seconds.list supplied and automatically updated by the tzdata package.

Please default to that for Debian based platforms, and maybe provide a way for wrapper cookbooks to easily supply their own. It saves you from having to maintain the leapseconds file in this cookbook.

I am aware that you can use a leapseconds mirror, but currently this cookbook defaults to an expired leapseconds file.

🥞 Cookbook version

3.12.4

👩‍🍳 Chef-Infra Version

17.10.3

🎩 Platform details

Operating system distribution and release version. Cloud provider if running in the cloud.

Ubunu 22.04

@hrak
Copy link
Contributor Author

hrak commented Feb 16, 2023

Apparently Redhat based platforms have their leapseconds file at /usr/share/zoneinfo/leapseconds, so this could apply to those as well.

@bugoff
Copy link
Contributor

bugoff commented Jan 24, 2024

@hrak do you know if this also matches fedora and amazon? There is already a case for this, so i could add it to this

when 'rhel', 'fedora', 'amazon'
default['ntp']['packages'] = %w(ntp ntpdate) if node['platform_version'].to_i >= 7
default['ntp']['driftfile'] = "#{node['ntp']['varlibdir']}/drift"

@bugoff bugoff mentioned this issue Jan 24, 2024
3 tasks
damacus added a commit that referenced this issue Feb 14, 2024
Updated readme this cookbook only supports Chef 15.5+ 

Since Debian Bookworm the NTP user is ntpsec (i expect Debian will continue to use this in all later versions)

For Debian / RedHat based OS'es there is a leap-second file, prefer using this.

# Issues Resolved

- Readme 
  #230

- bookworm
  #234
  #224

- leap-second file
  #217

---------

Co-authored-by: Dan Webb <[email protected]>
@damacus
Copy link
Member

damacus commented Feb 14, 2024

Closed via #242

@damacus damacus closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants