-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: refactor the internal Rust API to support container-level functionality #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…water into fix_skip_test
…water into refactor_gather_csv
…water into factor_out_rust_api
…water into factor_out_rust_api
ctb
changed the title
WIP: refactor the internal Rust API to support container-level functionality
MRG: refactor the internal Rust API to support container-level functionality
Jan 7, 2025
@bluegenes ready for review! |
bluegenes
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The additional layer of abstraction seems pretty clean here, excited for what it can enable 🎉
cleanliness FTW! we've learned so much 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out an internal Rust API into new
_obj
functions for many of the search commands in the branchwater plugin, to provide better separation between the CLI and the internal Rust API. The ultimate goal is to build out an intermediate container-level Python API in #552, but that was getting messy between the Rust changes, pyo3 layer additions, and Python tests! Hence, this PR, which will probably involve minimal changes to the CLI and the tests. See #552 for some of the cool new stuff this enables.This is all refactoring, no new functionality.
A few other features of note - this PR
println
andeprintln
progress & error reporting to the CLI-level stuffexpect
instead of raising an explicitErr
Box<dyn std::error::Error>
stuff, and manages it via a mixture ofanyhow
and?
conversionn_processed
etc) while keeping the CLI layer focused on reporting exit codesTODO:
@CTB
notesclone
s out