Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over useful code from #428, to try anew.
This PR -
Collection
,Manifest
, andRecord
;load_from
hook to support loading files via new wrapping;Next steps:
Record
to provide getters for private elementsksize
,scaled
,num
,with_abundance
, andn_hashes
;Index
protocol - in particular, providing sketches that are compatible with the FFI layer, and supportingfind
,prefetch
, andpeek
;Other notes:
pyo3-ffi - might this let us work directly with FFI interface in sourmash?
Limit to rocksdb loading? And/or provide env variable switch to turn loading on and off?