Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: try out lower level pyo3 API #552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

EXP: try out lower level pyo3 API #552

wants to merge 2 commits into from

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Dec 21, 2024

Copy over useful code from #428, to try anew.


This PR -

  • provides an initial wrapping of Collection, Manifest, and Record;
  • adds a load_from hook to support loading files via new wrapping;

Next steps:

  • adjust Record to provide getters for private elements ksize, scaled, num, with_abundance, and n_hashes;
  • think about how to support more of the Index protocol - in particular, providing sketches that are compatible with the FFI layer, and supporting find, prefetch, and peek;

Other notes:

pyo3-ffi - might this let us work directly with FFI interface in sourmash?

Limit to rocksdb loading? And/or provide env variable switch to turn loading on and off?

@ctb ctb changed the title EXP: steal code from branch_api EXP: try out lower level pyo3 API Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant