EXP: implement some intermediate APIs on top of Rust using pyo3 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…water into ctb_misc_cleanup
…water into ctb_misc2
…water into ctb_misc2
…water into ctb_misc_cleanup
#434) * preliminary victory * compiles and mostly runs * cleanup, split to new module * cleanup and comment * more cleanup of diff * cargo fmt * fix fmt * restore n_failed * comment failing test * cleanup and de-vec * create module/submodule structure * comment for later * get rid of vec * beg for help * cleanup and doc
This was referenced Dec 21, 2024
|
copying the useful bits over to #552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: PR into #424
Includes #430
Playing around with some pyo3 stuff.
This PR -
Collection,Manifest, andRecord;load_fromhook to support loading files via new wrapping;Next steps:
Recordto provide getters for private elementsksize,scaled,num,with_abundance, andn_hashes;Indexprotocol - in particular, providing sketches that are compatible with the FFI layer, and supportingfind,prefetch, andpeek;Other notes:
pyo3-ffi - might this let us work directly with FFI interface in sourmash?
Limit to rocksdb loading? And/or provide env variable switch to turn loading on and off?