MRG: propagate zipfile errors #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #3431 +/- ##
==========================================
- Coverage 86.43% 86.42% -0.02%
==========================================
Files 137 137
Lines 16103 16103
Branches 2219 2219
==========================================
- Hits 13919 13917 -2
- Misses 1877 1879 +2
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@luizirber ready for review! Will need to bump the sourmash version b/c of header change, I'll deal with that too. |
luizirber
approved these changes
Dec 15, 2024
ctb
added a commit
that referenced
this pull request
Dec 20, 2024
## [0.18.0] - 2024-12-20 MSRV: 1.66 Changes/additions: * add skipmer capacity to sourmash python layer via ffi (#3446) * add skipmers; switch to reading frame approach for translation, skipmers (#3395) * Refactor: Use to_writer/from_reader across the codebase (#3443) * adjust `Signature::name()` to return `Option<String>` instead of `filename()` and `md5sum()` (#3434) * propagate zipfile errors (#3431) Updates: * Bump proptest from 1.5.0 to 1.6.0 (#3437) * Bump roaring from 0.10.8 to 0.10.9 (#3438) * Bump serde from 1.0.215 to 1.0.216 (#3436) * Bump statrs from 0.17.1 to 0.18.0 (#3426) * Bump roaring from 0.10.7 to 0.10.8 (#3423) * Bump needletail from 0.6.0 to 0.6.1 (#3427) * Bump web-sys from 0.3.72 to 0.3.74 (#3411) * Bump js-sys from 0.3.72 to 0.3.74 (#3412) * Bump roaring from 0.10.6 to 0.10.7 (#3413) * Bump serde_json from 1.0.132 to 1.0.133 (#3402) * Bump serde from 1.0.214 to 1.0.215 (#3403)
2 tasks
bluegenes
added a commit
to sourmash-bio/sourmash_plugin_directsketch
that referenced
this pull request
Dec 27, 2024
This PR integrates the changes to `BuildUtils` (`MultiSelection` details, minor changes to `BuildCollection` filtering + writing) that arose from integration into branchwater. It also makes the number of simultaneous downloads tunable, since I was having trouble when using the 3 default permits with large eukaryotic genomes. It also handles changes associated with zipfile handling from sourmash-bio/sourmash#3431 arising from updating sourmash core to 0.18.0 ref #134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from
ZipStorageBuildertoZipStorageTryBuilderin order to propagate errors from bad zip files.Fixes #3430