You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
will panic, presumably because of the second unwrap() which fails to handle ZipArchive errors.
When I try to switch the second unwrap to a ?, I get:
error[E0277]: the `?` operator can only be used in a closure that returns `Result` or `Option` (or another type that implements `FromResidual`)
--> src/core/src/storage/mod.rs:409:64
|
408 | archive_builder: |mapping: &Option<memmap2::Mmap>| {
| --------------------------------- this function should return `Result` or `Option` to accept `?`
409 | piz::ZipArchive::new(mapping.as_ref().unwrap())?
| ^ cannot use the `?` operator in a closure that returns `ZipArchive<'_>`
|
= help: the trait `FromResidual<std::result::Result<Infallible, ZipError>>` is not implemented for `ZipArchive<'_>`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `sourmash` (lib) due to 1 previous error
which I vaguely understand ;).
I feel like the right thing to do is to move this outside the builder, but not sure.
The text was updated successfully, but these errors were encountered:
If you run
ZipStorage::fromfile
,sourmash/src/core/src/storage/mod.rs
Line 402 in 7362b43
this code
will panic, presumably because of the second
unwrap()
which fails to handleZipArchive
errors.When I try to switch the second
unwrap
to a?
, I get:which I vaguely understand ;).
I feel like the right thing to do is to move this outside the builder, but not sure.
The text was updated successfully, but these errors were encountered: