Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CodyAgentClient to kotlin #2048

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 14, 2024

It will make #2040 implementation easier and we are still moving to Kotlin anyway.

Test plan

No functional changes expected.

@mkondratek mkondratek self-assigned this Aug 14, 2024
@mkondratek mkondratek force-pushed the mkondratek/chore/migrate-cody-agent-client-to-kotlin branch 3 times, most recently from 7f629fe to 58aca73 Compare August 19, 2024 06:41
@mkondratek mkondratek enabled auto-merge (squash) August 19, 2024 06:50
pkukielka pushed a commit that referenced this pull request Aug 19, 2024
… protocol (#2049)

<!-- start git-machete generated -->

# Based on PR #2048

## Full chain of PRs as of 2024-08-14

* PR #2049:
`mkondratek/chore/use-generated-protocol-for-inline-edits` ➔
`mkondratek/chore/migrate-cody-agent-client-to-kotlin`
* PR #2048:
  `mkondratek/chore/migrate-cody-agent-client-to-kotlin` ➔ `main`

<!-- end git-machete generated -->



## Test plan
- No functional changes expected. 
- `Inline Edit` should be re-verified.
@mkondratek mkondratek disabled auto-merge August 19, 2024 06:54
import org.hamcrest.Matchers.startsWith
import org.junit.Assert.assertThat
import org.junit.Test
import org.junit.runner.RunWith

@RunWith(CustomJunitClassRunner::class)
class DocumentCodeTest : CodyIntegrationTextFixture() {
@Ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkukielka pkukielka merged commit 3e9c9e9 into main Aug 19, 2024
6 of 9 checks passed
@pkukielka pkukielka deleted the mkondratek/chore/migrate-cody-agent-client-to-kotlin branch August 19, 2024 07:41
mkondratek added a commit that referenced this pull request Aug 19, 2024
… protocol (#2060)

<!-- start git-machete generated -->

It's #2049 once again 😃 

# Based on PR #2048

## Full chain of PRs as of 2024-08-19

* PR #2060:
`mkondratek/chore/use-generated-protocol-for-inline-edits` ➔
`mkondratek/chore/migrate-cody-agent-client-to-kotlin`
* PR #2048:
  `mkondratek/chore/migrate-cody-agent-client-to-kotlin` ➔ `main`

<!-- end git-machete generated -->



## Test plan
- No functional changes expected. 
- `Inline Edit` should be re-verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants