Migrate CodyAgentClient to kotlin #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
force-pushed
the
mkondratek/chore/migrate-cody-agent-client-to-kotlin
branch
3 times, most recently
from
7f629fe
to
58aca73
Compare
pkukielka
pushed a commit
that referenced
this pull request
Aug 19, 2024
… protocol (#2049) <!-- start git-machete generated --> # Based on PR #2048 ## Full chain of PRs as of 2024-08-14 * PR #2049: `mkondratek/chore/use-generated-protocol-for-inline-edits` ➔ `mkondratek/chore/migrate-cody-agent-client-to-kotlin` * PR #2048: `mkondratek/chore/migrate-cody-agent-client-to-kotlin` ➔ `main` <!-- end git-machete generated --> ## Test plan - No functional changes expected. - `Inline Edit` should be re-verified.
mkondratek
force-pushed
the
mkondratek/chore/migrate-cody-agent-client-to-kotlin
branch
from
495296b
to
d75742c
Compare
pkukielka
reviewed
Aug 19, 2024
| import org.hamcrest.Matchers.startsWith | ||
| import org.junit.Assert.assertThat | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
|
|
||
| @RunWith(CustomJunitClassRunner::class) | ||
| class DocumentCodeTest : CodyIntegrationTextFixture() { | ||
| @Ignore |
There was a problem hiding this comment.
Let's double check it's not a regression. Running a comparison tests here:
https://github.com/sourcegraph/jetbrains/actions/runs/10448681659
https://github.com/sourcegraph/jetbrains/actions/runs/10448680193
pkukielka
deleted the
mkondratek/chore/migrate-cody-agent-client-to-kotlin
branch
mkondratek
added a commit
that referenced
this pull request
Aug 19, 2024
… protocol (#2060) <!-- start git-machete generated --> It's #2049 once again 😃 # Based on PR #2048 ## Full chain of PRs as of 2024-08-19 * PR #2060: `mkondratek/chore/use-generated-protocol-for-inline-edits` ➔ `mkondratek/chore/migrate-cody-agent-client-to-kotlin` * PR #2048: `mkondratek/chore/migrate-cody-agent-client-to-kotlin` ➔ `main` <!-- end git-machete generated --> ## Test plan - No functional changes expected. - `Inline Edit` should be re-verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will make #2040 implementation easier and we are still moving to Kotlin anyway.
Test plan
No functional changes expected.