Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate text- and workspace- edit operation protocol to the generated protocol #2049

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 14, 2024

Based on PR #2048

Full chain of PRs as of 2024-08-14

Test plan

  • No functional changes expected.
  • Inline Edit should be re-verified.

@mkondratek mkondratek self-assigned this Aug 14, 2024
@mkondratek mkondratek force-pushed the mkondratek/chore/use-generated-protocol-for-inline-edits branch 4 times, most recently from 61428cb to ffaccfa Compare August 14, 2024 18:05
@mkondratek mkondratek force-pushed the mkondratek/chore/migrate-cody-agent-client-to-kotlin branch from bf22626 to 63c2588 Compare August 14, 2024 18:34
@mkondratek mkondratek force-pushed the mkondratek/chore/use-generated-protocol-for-inline-edits branch from ffaccfa to cf40ce9 Compare August 14, 2024 18:34
@mkondratek mkondratek force-pushed the mkondratek/chore/migrate-cody-agent-client-to-kotlin branch from 63c2588 to 7f629fe Compare August 14, 2024 18:43
@mkondratek mkondratek force-pushed the mkondratek/chore/use-generated-protocol-for-inline-edits branch from cf40ce9 to 37663d4 Compare August 14, 2024 18:43
@mkondratek mkondratek force-pushed the mkondratek/chore/migrate-cody-agent-client-to-kotlin branch from 7f629fe to 58aca73 Compare August 19, 2024 06:41
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek force-pushed the mkondratek/chore/use-generated-protocol-for-inline-edits branch from 37663d4 to ab3d215 Compare August 19, 2024 06:41
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkukielka pkukielka merged commit 495296b into mkondratek/chore/migrate-cody-agent-client-to-kotlin Aug 19, 2024
6 of 7 checks passed
@pkukielka pkukielka deleted the mkondratek/chore/use-generated-protocol-for-inline-edits branch August 19, 2024 06:54
mkondratek added a commit that referenced this pull request Aug 19, 2024
… protocol (#2060)

<!-- start git-machete generated -->

It's #2049 once again 😃 

# Based on PR #2048

## Full chain of PRs as of 2024-08-19

* PR #2060:
`mkondratek/chore/use-generated-protocol-for-inline-edits` ➔
`mkondratek/chore/migrate-cody-agent-client-to-kotlin`
* PR #2048:
  `mkondratek/chore/migrate-cody-agent-client-to-kotlin` ➔ `main`

<!-- end git-machete generated -->



## Test plan
- No functional changes expected. 
- `Inline Edit` should be re-verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants