Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Restart Cody action #1965

Merged

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Jul 31, 2024

Related to #1964.

This PR exposes Restart Cody action (formerly Restart Cody Agent).

  • a notification with the action appears on the start up timeout
  • the action is added to the widget group on the error
  • starting timeout error is no longer an IDE error
  • restart cody agent has 90s (twice as the regular starting) timeout

Test plan

  1. Change secondsTimeout to 1 to test it.
  2. Review the notification and the widget action.

Demo

image image

@mkondratek mkondratek self-assigned this Jul 31, 2024
@mkondratek mkondratek changed the title Do not error on startAgent timeout Expose Restart Cody action Jul 31, 2024
@@ -189,7 +189,8 @@ class CodyAgentService(private val project: Project) : Disposable {
logger.error(msg)
throw (CodyAgentException(msg))
}
val agent = future.get(45, TimeUnit.SECONDS)

val agent = future.get(secondsTimeout, TimeUnit.SECONDS)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change secondsTimeout to 1 to test it.

@mkondratek mkondratek enabled auto-merge (squash) August 5, 2024 09:53
CodyStatus.CodyAgentNotRunning) {
addAll(
OpenLogAction(),
AboutAction().apply { templatePresentation.text = "Open About To Troubleshoot Issue" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AboutAction here seems to be redundant. It makes the action group overpopulated. The GitHub report fills the about info automatically.

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek changed the base branch from main to pkukielka/improve-integration-tests August 5, 2024 13:37
@mkondratek mkondratek merged commit 606b29e into pkukielka/improve-integration-tests Aug 5, 2024
6 of 8 checks passed
@mkondratek mkondratek deleted the mkondratek/restart-cody branch August 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants