Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose ModelsService.changes and listen to that in ChatController #5578

Merged
merged 1 commit into from
Sep 15, 2024

Commits on Sep 15, 2024

  1. expose ModelsService.changes and listen to that in ChatController

    Previously, the ChatController listened for auth changes and assumed that model changes would have been already applied. This required a specific ordering of operations in the AuthProvider, which was a brittle way of ensuring this behavior (and the `chat model selector` e2e test broke when that behavior was slightly changed). Now, the ModelsService exposes a `changes` observable and the ChatController listens to that to follow changes to models, which makes sense.
    sqs committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c093512 View commit details
    Browse the repository at this point in the history