expose ModelsService.changes and listen to that in ChatController #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/modelssvc-observe
branch
2 times, most recently
from
768a625
to
3523799
Compare
sqs
changed the title
sqs
force-pushed
the
sqs/modelssvc-observe
branch
from
3523799
to
9c6a0ac
Compare
beyang
approved these changes
Sep 15, 2024
Previously, the ChatController listened for auth changes and assumed that model changes would have been already applied. This required a specific ordering of operations in the AuthProvider, which was a brittle way of ensuring this behavior (and the `chat model selector` e2e test broke when that behavior was slightly changed). Now, the ModelsService exposes a `changes` observable and the ChatController listens to that to follow changes to models, which makes sense.
sqs
force-pushed
the
sqs/modelssvc-observe
branch
from
9c6a0ac
to
c093512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ChatController listened for auth changes and assumed that model changes would have been already applied. This required a specific ordering of operations in the AuthProvider, which was a brittle way of ensuring this behavior (and the
chat model selectore2e test broke when that behavior was slightly changed). Now, the ModelsService exposes achangesobservable and the ChatController listens to that to follow changes to models, which makes sense.Test plan
e2e tests cover this well.