Add optional data parameter for client requests #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlast
commented
Jul 28, 2023
lib/shared/src/chat/client.ts
Outdated
| @@ -131,7 +141,7 @@ export async function createClient({ | |||
| isMessageInProgress = true | |||
| transcript.addInteraction(interaction) | |||
|
|
|||
| sendTranscript() | |||
| sendTranscript(options?.data) | |||
There was a problem hiding this comment.
What is the point of this sendTranscript here that sends an empty message?
There was a problem hiding this comment.
I'm not sure, I did not know what it is... maybe we can remove? I can check some more later
pjlast
commented
Jul 31, 2023
Comment on lines
-134
to
-135
| sendTranscript() | ||
|
|
There was a problem hiding this comment.
Not sure if this sendTranscript that sends an empty message serves any purpose. Removing it, unless instructed otherwise
There was a problem hiding this comment.
Hmm I don't know, it seems to get some transcript from the closure but I ran your changes and didn't notice a difference 🙈
philipp-spiess
approved these changes
Jul 31, 2023
Comment on lines
-134
to
-135
| sendTranscript() | ||
|
|
There was a problem hiding this comment.
Hmm I don't know, it seems to get some transcript from the closure but I ran your changes and didn't notice a difference 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
data?: anyparameter that's returned as-is to clients. This allows us to add something like amessageIDto completion requests and keep track of which request we're receiving back.This is especially useful for streaming responses, where we'd like to be able to handle different streamed responses concurrently, and route them based on the message ID.
Also, instead of returning
nullwhen the message is done, it returns only thedatafield (if present). This way we know that that message is finished and we can handle it appropriately.Test plan
🤞