Use a callback function table to handle streaming response messages #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdevries
reviewed
Jul 28, 2023
lua/sg/cody/rpc.lua
Outdated
|
|
||
| M.message_callbacks[message_id] = callback | ||
|
|
||
| return M.request("recipes/execute", { id = "chat-question", humanChatInput = message, data = message_id }) |
There was a problem hiding this comment.
can we make the data be { id = message_id }?
tjdevries
reviewed
Jul 28, 2023
| return string.format("%x", v) | ||
| end) | ||
| end | ||
|
|
There was a problem hiding this comment.
can also just add a rust dep for this if you want to generate one.
|
(also, did you do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on sourcegraph/cody#438
Allows specifying a callback function when invoking a chat with a streamed response.
The callback is cleaned up when the streamed response ends.
This gives us a lot of flexibility in how we handle streamed responses.