PromptString linter: Only error when the reported violation is within one of the changed range #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one of the changed ranges
This was referenced Apr 16, 2024
|
|
philipp-spiess
commented
Apr 16, 2024
| @@ -1255,3 +1255,6 @@ function newChatModelFromSerializedChatTranscript( | |||
| function isAbortError(error: Error): boolean { | |||
| return error.message === 'aborted' || error.message === 'socket hang up' | |||
| } | |||
|
|
|||
| // Only this unsafe usage should be report | |||
| PromptString.unsafe_fromUserQuery('EVIL!') | |||
There was a problem hiding this comment.
As you can see only this violation was reported, not the other violations in this file
philipp-spiess
commented
Apr 16, 2024
|
|
||
| const EXTENSIONS = ['ts', 'tsx'] | ||
|
|
||
| exec('git diff --unified=0 origin/main', (error, stdout, stderr) => { |
umpox
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggest, we only want to emit linter errors when new call sites were added. The previous rule would fire too often.
Test plan
vscode/src/chat/chat-view/SimpleChatPanelProvider.tsthat adds anunsafe_API callpnpm ts-node lints/safe-prompts.tspnpm ts-node lints/git-diff-ts-ranges.ts`