-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot: Show auth connection issues #3750
Conversation
Extends the UI to cover the full viewport making it easier to try the UI on different sizes.
…g/connection_issues
…g/connection_issues
…g/connection_issues
6a7f279
to
6de5e4c
Compare
@sourcegraph/cody-clients Does this affect JB's in any way? I had to update the Kotlin protocols but I'm not sure if that was the correct approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments inline. The only concern i have is about the reset function, but the rest looks good to me. Nice work!
Yeah I'll probably just change that to a sign out. I just didn't want someone to get stuck with bad settings and not get back to the sign in screen. Thanks for taking a look |
I've decided to remove the "fullReset" and "showOutput" logs in favor of another feature coming soon to help users enable and navigate debug mode/troubleshooting mode more easily. So this screen will only allow you to retry or sign-out explicitly. The problem with some of the other commands is that they are tied to specific UI clicks and handle all the analytics as well (which I think is a different problem altogether). But I'll see if I can simplify it somewhat. Although there will be 4-5 commands coming to the troubleshoot namespace soon |
- Only offer sign-out to prevent the user accidentally ending up in a locked state if anything is wrong with the auth. (e.g. switched endpoints) - The debug / full reset functionality will be moved to specific UI & features in coming PR's
…g/connection_issues
|
@RXminuS sorry regarding the message above, see: #3797 (comment) Fix incoming: #3810 |
…g/connection_issues
@philipp-spiess increasing the timeout fixed the e2e tests 👍 thanks for the help |
…g/connection_issues
Nice! This design is looking good too. For the width/positioning, use VS Code’s Run & Debug panel and responsive breakpoints as the guide: CleanShot.2024-04-17.at.11.24.01.mp4i.e. icon & buttons are full width until a point, then left aligned |
…g/connection_issues
More consistent with VSCode UI
…g/connection_issues
@toolmantim VScode had a few inconsistent breakpoints so I just picked CleanShot.2024-04-17.at.14.36.07.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and for adding all those amazing tests! Confirm the chat panel is now showing up correctly on reload, and we can look into the Loading page issue separately 😄 well done!
Fixes #3673 where we mistakingly show a signIn screen if there are connectivity issues to the Cody server.
Test plan