Fix linux build and QT Deprecations #3305
Conversation
|
@contra-bit - thanks so much for this. One question I have is why including QtQuick was necessary? I'm pretty sure it's not used. Perhaps it pulls in deps which are? (In which case it might be better to be more specific rather than relying on transitive deps?) @lilyinstarlight - do you have any comments on these commits? |
This reverts commit 4280ab4.
|
Good call, I just removed the QtQuick and could still build. Prior I added QtQuck, due to this error: QQuickWindow: No such file or directory. Please note, that I have reverted the addition of QtQuick. |
|
@contra-bit thanks for checking and reverting the QtQuick addition. One other thing is that I'm a bit wary of patching upstream deps (as you have done with atomic). I've therefore taken this opportunity to update active_support to the latest version which drops thread_safe/atomic in preference for concurrent_ruby. I'm therefore interested to know if this fixes/messes things up for you in linux land. I'm hoping it should be fine... |
Switches transient gems - thread_safe and atomic are replaced with concurrent_ruby. tzinfo is also pulled in.
Recent Ruby versions introduced a detailed_message method to Exception which includes the useful "did you mean" information which was dropped from the message method.
|
I can confirm, that removing atomic_reference.c does not break the build :) |
|
@contra-bit - great. Any chance you could fix the conflict so I can run the CI tests? |
|
Yes. Thanks for asking. I overlooked that merge conflict. I am so gratefull for your work. Thaks alot. I learn so much about sonic pi and tau this week. I appreciate your time and effort, espcially your fast and high quality responses ❤️ 🎧 🎉 🥧 |
|
This resolve was weird (0 bits changed) . I manually deleted atomic_reference.c, please check if there are any other files, which have reappeared. |
|
@contra-bit - thanks so much for this - hugely appreciated! |
This fixes #3292 and subsequent errors mentioned in the issue.
Also this fixes most QT deprecation warnings.
Please merge,