Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary GCC workaround #3306

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

contra-bit
Copy link
Contributor

This reverts one workaround which was added in #3305. The issue with #3292 does not occur anymore. Vcpkg now also builds with gcc13.

I have tested this on my laptop and desktop (arm64)

@MightyPork
Copy link

MightyPork commented Jul 11, 2023

reproc error persists for me (Arch Linux, GCC 13.1.1). Did a fresh clone from your fork.

Build with linux-build-all.sh fails almost immediately.

The unit tests here use GCC 11 so thats a bit misleading...

Building reproc:x64-linux...
-- Downloading https://github.com/DaanDeMeyer/reproc/archive/v14.2.4.tar.gz -> DaanDeMeyer-reproc-v14.2.4.tar.gz...
-- Extracting source /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/downloads/DaanDeMeyer-reproc-v14.2.4.tar.gz
-- Using source at /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean
-- Found external ninja('1.11.1').
-- Configuring x64-linux
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: /usr/bin/cmake --build . --config Debug --target install -- -v -j13
    Working Directory: /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/x64-linux-dbg
    See logs for more information:
      /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/reproc/portfile.cmake:17 (vcpkg_cmake_install)
  scripts/ports.cmake:147 (include)


error: building reproc:x64-linux failed with: BUILD_FAILED
Elapsed time to handle reproc:x64-linux: 1.4 s
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+reproc
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?title=[reproc]+Build+error&body=Copy+issue+body+from+%2Fhome%2Fondra%2Ftmp%2Fsonic-pi-cbit%2Fapp%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

logs

In file included from /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/src/reproc.cpp:1:
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:95:5: error: declaration of ‘reproc::options::<unnamed struct> reproc::options::env’ changes meaning of ‘env’ [-Wchanges-meaning]
   95 |   } env = {};
      |     ^~~
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:91:5: note: used here to mean ‘class reproc::env’
   91 |     env::type behavior;
      |     ^~~
In file included from /home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:11:
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/env.hpp:8:7: note: declared here
    8 | class env : public detail::array {
      |       ^~~
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:107:5: error: declaration of ‘reproc::options::<unnamed struct> reproc::options::redirect’ changes meaning of ‘redirect’ [-Wchanges-meaning]
  107 |   } redirect = {};
      |     ^~~~~~~~
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:102:5: note: used here to mean ‘struct reproc::redirect’
  102 |     redirect err;
      |     ^~~~~~~~
/home/ondra/tmp/sonic-pi-cbit/app/vcpkg/buildtrees/reproc/src/v14.2.4-061178cb57.clean/reproc++/include/reproc++/reproc.hpp:68:8: note: declared here
   68 | struct redirect {
      |        ^~~~~~~~
ninja: build stopped: subcommand failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants