Handle learning duplicate IPs on different VRFs #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one. - For all other scenarios, proceed with neighbor learning normally. Signed-off-by: Lawrence Lee <[email protected]>
dgsudharsan
previously approved these changes
May 24, 2024
|
@theasianpianist , can you fix coverage? |
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
|
@dgsudharsan Github is showing that you left some review comments, but I am unable to see them for some reason, can you please re-review w/ new changes? |
dgsudharsan
previously approved these changes
May 24, 2024
prsunny
reviewed
May 28, 2024
| { | ||
| SWSS_LOG_NOTICE("Neighbor %s already learned on %s, removing before adding new neighbor", ip_address.to_string().c_str(), vlan_port.c_str()); | ||
| } | ||
| { |
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
reviewed
May 28, 2024
orchagent/neighorch.cpp
Outdated
| if (vrf_name.empty()) | ||
| { | ||
| SWSS_LOG_NOTICE("Neighbor %s already learned on %s, removing before adding new neighbor", ip_address.to_string().c_str(), vlan_port.c_str()); | ||
| } else { |
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
approved these changes
May 29, 2024
|
@theasianpianist would you please create a separate PR for 202311? |
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jun 1, 2024
- What I did Fixes sonic-net/sonic-buildimage#18890 If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one. For all other scenarios, proceed with neighbor learning normally. - Why I did it Allow learning the same IP in two different VRFs - How I verified it Run the C++ unit tests Signed-off-by: Lawrence Lee <[email protected]> Co-authored-by: Prince Sunny <[email protected]>
yxieca
pushed a commit
that referenced
this pull request
Jun 3, 2024
- What I did Fixes sonic-net/sonic-buildimage#18890 If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one. For all other scenarios, proceed with neighbor learning normally. - Why I did it Allow learning the same IP in two different VRFs - How I verified it Run the C++ unit tests Signed-off-by: Lawrence Lee <[email protected]> Co-authored-by: Prince Sunny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes sonic-net/sonic-buildimage#18890
Why I did it
Allow learning the same IP in two different VRFs
How I verified it
Run the C++ unit tests
Details if related