Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202311] Handle learning duplicate IPs on different VRFs (#3165) #3179

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

theasianpianist
Copy link
Contributor

202311 cherry-pick of #3165

What I did
Fixes sonic-net/sonic-buildimage#18890

  • If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one.
  • For all other scenarios, proceed with neighbor learning normally.

Why I did it
Allow learning the same IP in two different VRFs

How I verified it
Run the C++ unit tests

Details if related

- What I did
Fixes sonic-net/sonic-buildimage#18890

If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one.
For all other scenarios, proceed with neighbor learning normally.

- Why I did it
Allow learning the same IP in two different VRFs

- How I verified it
Run the C++ unit tests

Signed-off-by: Lawrence Lee <[email protected]>
Co-authored-by: Prince Sunny <[email protected]>
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keboliu
Copy link
Collaborator

keboliu commented Jun 2, 2024

@yxieca would you please merge?

@yxieca yxieca merged commit 5a998b6 into sonic-net:202311 Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants