Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Overlap - RSC-834 #595

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dropdown Overlap - RSC-834 #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75c7e9a
Change z-index
avnvbhatta Dec 16, 2021
777acad
Version bump
avnvbhatta Dec 16, 2021
cdfa032
Add z-index to page-.nx-page-sidebar
avnvbhatta Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gallery/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@sonatype/react-shared-components-gallery",
"version": "9.5.1",
"version": "9.5.2",
"description": "Gallery application to demonstrate usage and look of Sonatype shared UI components",
"main": "src/main.ts",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@sonatype/react-shared-components",
"version": "9.5.1",
"version": "9.5.2",
"description": "Sonatype shared UI components and utilities written in React",
"main": "index.js",
"repository": {
Expand Down
2 changes: 2 additions & 0 deletions lib/src/base-styles/_nx-page-layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
padding: var(--nx-spacing-6x) var(--nx-spacing-6x) var(--nx-spacing-2x) var(--nx-spacing-6x);
position: relative;
white-space: normal;
z-index: 0;
}

.nx-page-main {
Expand All @@ -106,6 +107,7 @@
overflow-y: auto;
padding: var(--nx-spacing-6x) var(--nx-spacing-6x);
white-space: normal;
z-index: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably also be added to .nx-page-sidebar so that a dropdown in a sidebar doesn't have the same problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably also be added to .nx-page-sidebar so that a dropdown in a sidebar doesn't have the same problem

Added here: cdfa032

}

.nx-html--page-scrolling {
Expand Down