Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Overlap - RSC-834 #595

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dropdown Overlap - RSC-834 #595

wants to merge 3 commits into from

Conversation

avnvbhatta
Copy link
Contributor

@avnvbhatta avnvbhatta requested a review from a team December 16, 2021 14:47
rpokorny
rpokorny reviewed Dec 16, 2021
View reviewed changes
lib/src/base-styles/_nx-page-layout.scss
@@ -106,6 +106,7 @@
overflow-y: auto;
padding: var(--nx-spacing-6x) var(--nx-spacing-6x);
white-space: normal;
z-index: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably also be added to .nx-page-sidebar so that a dropdown in a sidebar doesn't have the same problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably also be added to .nx-page-sidebar so that a dropdown in a sidebar doesn't have the same problem

Added here: cdfa032

rpokorny
rpokorny approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@rpokorny rpokorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but with some hesitation. This is the kind of change that could cause some obscure bug somewhere completely unrelated to dropdowns. This should be tested carefully and obviously any applitools differences should be taken seriously.

@avnvbhatta
Copy link
Contributor Author

+1 but with some hesitation. This is the kind of change that could cause some obscure bug somewhere completely unrelated to dropdowns. This should be tested carefully and obviously any applitools differences should be taken seriously.

I agree. I mean if we haven't heard about this issue from downstream users, so maybe a safer approach is to update the z-index of the header?

@rpokorny
Copy link
Contributor

I agree. I mean if we haven't heard about this issue from downstream users, so maybe a safer approach is to update the z-index of the header?

That's probably just as dangerous. It could result in the header appearing in front of modals or something. Actually, this fix might cause that too but in a different way. Maybe do some testing before you merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpokorny rpokorny rpokorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avnvbhatta @rpokorny