Revenue & Cashflow Profile #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date Util_eff to allow for temperatures above 373 by assuming efficiency os the same, given the plant is the same (usually flash)
…e and Payoff years
… code (commented out)
…specific output file
Closed
… (can be re-added if issue/repro/unit test are identified)
| @@ -84,6 +85,7 @@ | |||
| 0.4, | |||
| 0.4, | |||
| 0.4, | |||
| 0.4, | |||
There was a problem hiding this comment.
@malcolm-dsider Do we not expect utilization efficiency to increase between 374C and 600C?
| @@ -32,6 +32,7 @@ Simulation Metadata | |||
| Project IRR: 0.00 % | |||
| Project VIR=PI=PIR: -0.02 | |||
| Project MOIC: -0.72 | |||
| Project Payback Period: 0.00 yr | |||
There was a problem hiding this comment.
@malcolm-dsider Looks like an oversight?
There was a problem hiding this comment.
Oh, I see, payback period is 0.00 if NPV is negative (i.e. it will never payback)
There was a problem hiding this comment.
I changed output to be 'N/A' instead of 0.00
|
Yes, but we don’t have data on it, so I went with the safe answer of the same efficiency
From: Jonathan Pezzino ***@***.***>
Sent: Monday, March 4, 2024 12:22 PM
To: softwareengineerprogrammer/GEOPHIRES-X ***@***.***>
Cc: Malcolm Ross ***@***.***>; Mention ***@***.***>
Subject: Re: [softwareengineerprogrammer/GEOPHIRES-X] Revenue & Cashflow Profile (PR #16)
@softwareengineerprogrammer commented on this pull request.
_____
In src/geophires_x/GeoPHIRESUtils.py <#16 (comment)> :
@@ -84,6 +85,7 @@
0.4,
0.4,
0.4,
+ 0.4,
@malcolm-dsider <https://github.com/malcolm-dsider> Do we not expect utilization efficiency to increase between 374C and 600C?
—
Reply to this email directly, view it on GitHub <#16 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWGVYT3DV2MGY7IAY372WM3YWS3V7AVCNFSM6AAAAABEFM4SKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJUHE4TSNJYGQ> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AWGVYT4LSKGTPKWSNPUQL53YWS3V7A5CNFSM6AAAAABEFM4SKGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTSESJSA.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Merging this into my fork to designate it as acceptably stable/complete for PR into main repo. Will link main repo PR here once created. |
| @@ -493,15 +538,20 @@ def extract_table_header(lines: list) -> list: | |||
| return None | |||
|
|
|||
| def _get_ccus_profile(self): | |||
| """ | |||
| FIXME TODO - transform from revenue & cashflow if present (CCUS profile replaced by revenue & cashflow | |||
| profile in 49ff3a1213ac778ed53120626807e9a680d1ddcf) | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase & adaptation of malcolm-dsider#3
https://github.com/users/softwareengineerprogrammer/projects/3?pane=issue&itemId=49706715