-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1747516: Fix native libraries relocation #1927
Merged
sfc-gh-dprzybysz
merged 1 commit into
snowflakedb:master
from
laurentgo:laurentgo/native-libraries-relocation
Nov 26, 2024
Merged
SNOW-1747516: Fix native libraries relocation #1927
sfc-gh-dprzybysz
merged 1 commit into
snowflakedb:master
from
laurentgo:laurentgo/native-libraries-relocation
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors have signed the CLA ✍️ ✅ |
laurentgo
changed the title
Fix native libraries relocation
SNOW-1747516: Fix native libraries relocation
Oct 17, 2024
I have read the CLA Document and I hereby sign the CLA recheck |
recheck |
Native libraries used by conscrypt and grpc/netty are not relocated to a different name although their counterpart java classes are. This may cause a conflict with applications using the same dependencies but possibly different versions up to a JVM crash. Modify maven-shade-plugin relocation configuration to rename the libraries using snowflake shade base: * relocate grpc/netty tcnative and epoll libraries (note that Netty java loader detects relocation automatically as long as the base is the same for the java classes and the native library (minus dot '.' being replaced with underscore '_')) * relocate conscrypt native library and change the prefix used to find the library in NativeCryptoJni class
laurentgo
force-pushed
the
laurentgo/native-libraries-relocation
branch
from
November 22, 2024 16:48
d66d56a
to
348075e
Compare
I have read the CLA Document and I hereby sign the CLA |
recheck |
sfc-gh-pfus
approved these changes
Nov 25, 2024
sfc-gh-dprzybysz
approved these changes
Nov 26, 2024
sfc-gh-dprzybysz
merged commit Nov 26, 2024
f1038e6
into
snowflakedb:master
141 of 143 checks passed
@laurentgo thank you for the contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1747516
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX:
External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: SNOW-1747516: Native libraries are not relocated #1926
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi
(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Native libraries used by conscrypt and grpc/netty are not relocated to a different name although their counterpart java classes are. This may cause a conflict with applications using the same dependencies but possibly different versions up to a JVM crash.
Modify maven-shade-plugin relocation configuration to rename the libraries using snowflake shade base: