SNOW-1747516: Fix native libraries relocation #1973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native libraries used by conscrypt and grpc/netty are not relocated to a different name although their counterpart java classes are. This may cause a conflict with applications using the same dependencies but possibly different versions up to a JVM crash. Modify maven-shade-plugin relocation configuration to rename the libraries using snowflake shade base: * relocate grpc/netty tcnative and epoll libraries (note that Netty java loader detects relocation automatically as long as the base is the same for the java classes and the native library (minus dot '.' being replaced with underscore '_')) * relocate conscrypt native library and change the prefix used to find the library in NativeCryptoJni class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing #1927