Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1754295 - Start using subscoped tokens for iceberg ingestion #868

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

sfc-gh-hmadan
Copy link
Collaborator

  1. Add logic for invoking new server-side API (Refresh Table Information)
  2. Reuse InternalStage for all the JDBC interop. For this:
    1. pass in a tableRef into InternalStage
    2. Add a IStorageManager.getRefreshedLocation API that's called by InternalStage
  3. Add SubscopedTokenExternalVolumeManager that creates an InternalStage per table, and fetches new credentials via the new API from (1). InternalStage calls storageManager.getRefreshedLocation and doesn't care whether it is operating on an account's internal stage's streaming_ingest subfolder (FDN ingestion) or on a per-session location under the external volume's S3 location.
  4. Remove from InternalStage and InternalStageManager

Note that after this change, InternalStage can / should be renamed, did not want to make this PR even bigger thus haven't done that yet.

New tests for SubscopedTokenExtVolManager are pending. Sending this out for review + to see if any merge gate tests barf.

@sfc-gh-hmadan sfc-gh-hmadan requested review from sfc-gh-tzhang and a team as code owners October 21, 2024 06:44
Base automatically changed from hmadan-subscoped-1 to master October 21, 2024 17:51
@sfc-gh-hmadan sfc-gh-hmadan merged commit a4ca491 into master Oct 28, 2024
45 checks passed
@sfc-gh-hmadan sfc-gh-hmadan deleted the hmadan-subscoped-2 branch October 28, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants