pr comments

snowflakedb · Oct 25, 2024 · 3e75af2 · 3e75af2
1 parent 967d5ae
commit 3e75af2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java b/src/main/java/net/snowflake/ingest/streaming/internal/IStorageManager.java
@@ -48,8 +48,9 @@ interface IStorageManager {
   /**
    * Get the updated subscoped tokens and location info for this table
    *
-   * @param tableRef
-   * @param fileName
+   * @param tableRef The table for which to get the location
+   * @param fileName Legacy, was used by deprecated GCS codepaths when it didn't support subscoped
+   *     tokens. Not in use.
    * @return
    */
   FileLocationInfo getRefreshedLocation(TableRef tableRef, Optional<String> fileName);

diff --git a/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java b/src/main/java/net/snowflake/ingest/streaming/internal/SnowflakeServiceClient.java
@@ -99,7 +99,7 @@ GeneratePresignedUrlsResponse generatePresignedUrls(GeneratePresignedUrlsRequest
     return response;
   }
 
-  /** Generates a batch of presigned URLs for a table */
+  /** Fetches the latest sub-scoped tokens from the server for the requested table in the request */
   RefreshTableInformationResponse refreshTableInformation(RefreshTableInformationRequest request)
       throws IngestResponseException, IOException {
     RefreshTableInformationResponse response =

diff --git a/src/main/java/net/snowflake/ingest/utils/Constants.java b/src/main/java/net/snowflake/ingest/utils/Constants.java
@@ -49,7 +49,7 @@ public class Constants {
   public static final int BLOB_FILE_SIZE_SIZE_IN_BYTES = 8;
   public static final int BLOB_CHECKSUM_SIZE_IN_BYTES = 8;
   public static final int BLOB_CHUNK_METADATA_LENGTH_SIZE_IN_BYTES = 4;
-  public static final long THREAD_SHUTDOWN_TIMEOUT_IN_SEC = 30L;
+  public static final long THREAD_SHUTDOWN_TIMEOUT_IN_SEC = 300L;
   public static final String BLOB_EXTENSION_TYPE = "bdec";
   public static final int MAX_THREAD_COUNT = Integer.MAX_VALUE;
   public static final String CLIENT_CONFIGURE_ENDPOINT = "/v1/streaming/client/configure/";