Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-988870] Update commons-compress version for vulnerability #684

Closed
wants to merge 3 commits into from
Closed

[SNOW-988870] Update commons-compress version for vulnerability #684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bc3834
update compress version for vulnerability
sfc-gh-rcheng Feb 27, 2024
5e540ee
remove dep pom
sfc-gh-rcheng Feb 27, 2024
b69f04e
exclude from hadoop
sfc-gh-rcheng Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<codehaus.version>1.9.13</codehaus.version>
<commonscodec.version>1.15</commonscodec.version>
<commonscollections.version>3.2.2</commonscollections.version>
<commonscompress.version>1.21</commonscompress.version>
<commonscompress.version>1.26.0</commonscompress.version>
<commonsio.version>2.8.0</commonsio.version>
<commonslang3.version>3.12.0</commonslang3.version>
<commonslogging.version>1.2</commonslogging.version>
Expand Down Expand Up @@ -205,6 +205,10 @@
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason we exclude this?

Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not exclude from hadoop, but instead let's udpate also the transitive dependencies, which would violate the requireUpperBoundDeps enforcer rule. I opened a PR that updates all vulnerable dependencies: #693

<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.curator</groupId>
<artifactId>curator-client</artifactId>
Expand Down
Loading