Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-988870] Update commons-compress version for vulnerability #684

Closed
wants to merge 3 commits into from

Conversation

sfc-gh-rcheng
Copy link
Collaborator

Received report for CVE-2024-26308 vulnerability on org.apache.commons:commons-compress, so upgrading to 1.26 as suggested

@sfc-gh-rcheng sfc-gh-rcheng requested review from sfc-gh-tzhang and a team as code owners February 27, 2024 18:16
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ask @sfc-gh-lsembera to take a look, thanks!

@@ -205,6 +205,10 @@
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason we exclude this?

Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not exclude from hadoop, but instead let's udpate also the transitive dependencies, which would violate the requireUpperBoundDeps enforcer rule. I opened a PR that updates all vulnerable dependencies: #693

@@ -205,6 +205,10 @@
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

@sfc-gh-lsembera sfc-gh-lsembera Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not exclude from hadoop, but instead let's udpate also the transitive dependencies, which would violate the requireUpperBoundDeps enforcer rule. I opened a PR that updates all vulnerable dependencies: #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants