-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-988870] Update commons-compress version for vulnerability #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please ask @sfc-gh-lsembera to take a look, thanks!
@@ -205,6 +205,10 @@ | |||
<groupId>org.apache.avro</groupId> | |||
<artifactId>avro</artifactId> | |||
</exclusion> | |||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason we exclude this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not exclude from hadoop, but instead let's udpate also the transitive dependencies, which would violate the requireUpperBoundDeps enforcer rule. I opened a PR that updates all vulnerable dependencies: #693
@@ -205,6 +205,10 @@ | |||
<groupId>org.apache.avro</groupId> | |||
<artifactId>avro</artifactId> | |||
</exclusion> | |||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not exclude from hadoop, but instead let's udpate also the transitive dependencies, which would violate the requireUpperBoundDeps enforcer rule. I opened a PR that updates all vulnerable dependencies: #693
Received report for CVE-2024-26308 vulnerability on org.apache.commons:commons-compress, so upgrading to 1.26 as suggested