Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-936900 Use upgraded version of snappy-java #605

Merged
merged 2 commits into from
Oct 19, 2023
+6 −0
Merged

SNOW-936900 Use upgraded version of snappy-java #605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3742d
SNOW-936900 Use upgraded version of snappy-java
sfc-gh-lsembera Oct 18, 2023
4e7051d
Merge branch 'master' into lsembera/snyk-e2e-snappy-java
sfc-gh-lsembera Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,12 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.xerial.snappy</groupId>
<artifactId>snappy-java</artifactId>
<scope>runtime</scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make it test only since this is only for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not testing only, this is transitive dependency of hadoop-common

</dependency>

<!-- JUnit so that we can make some basic unit tests -->
<dependency>
<groupId>junit</groupId>
Expand Down
Loading