SNOW-936900 Use upgraded version of snappy-java #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK is exporting an old version of its transitive dependency snappy-java . This is visible in the new e2e jar project, which is pulling in the snappy-java defined in hadoop-common and not the version we define in dependencyManagement. This PR makes snappy-java a direct dependency, so we can control the version.
sfc-gh-lsembera
requested review from
sfc-gh-tzhang and
a team
as code owners
sfc-gh-tjones
approved these changes
Oct 18, 2023
| <dependency> | ||
| <groupId>org.xerial.snappy</groupId> | ||
| <artifactId>snappy-java</artifactId> | ||
| <scope>runtime</scope> |
There was a problem hiding this comment.
should we make it test only since this is only for testing?
There was a problem hiding this comment.
It is not testing only, this is transitive dependency of hadoop-common
sfc-gh-tzhang
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK is exporting an old version of its transitive dependency snappy-java. This is visible in the new
e2e-jar-testproject, which is pulling insnappy-javaversion defined inhadoop-commonand not the version we define independencyManagement. This PR makessnappy-javaa direct runtime dependency, so we can control the version.