SNOW-918949: Add row index information to all exceptions

src/main/java/net/snowflake/ingest/streaming/internal/AbstractRowBuffer.java

@@ -260,7 +260,7 @@ Set<String> verifyInputColumns(
       throw new SFException(
           ErrorCode.INVALID_FORMAT_ROW,
           "Extra columns: " + extraCols,
-          "Columns not present in the table shouldn't be specified.");
+          "Columns not present in the table shouldn't be specified. Row Index:%d");
     }
 
     // Check for missing columns in the row
@@ -278,7 +278,7 @@ Set<String> verifyInputColumns(
       throw new SFException(
           ErrorCode.INVALID_FORMAT_ROW,
           "Missing columns: " + missingCols,
-          "Values for all non-nullable columns must be specified.");
+          "Values for all non-nullable columns must be specified. Row Index:%d");
     }
 
     return inputColNamesMap.keySet();

src/main/java/net/snowflake/ingest/streaming/internal/DataValidationUtil.java

@@ -457,7 +457,10 @@ static TimestampWrapper validateAndParseTimestamp(
     if (offsetDateTime.getYear() < 1 || offsetDateTime.getYear() > 9999) {
       throw new SFException(
           ErrorCode.INVALID_VALUE_ROW,
-          "Timestamp out of representable inclusive range of years between 1 and 9999");
+          String.format(
+              "Timestamp out of representable inclusive range of years between 1 and 9999, Row"
+                  + " Index:%d",
+              insertRowIndex));
     }
     return new TimestampWrapper(offsetDateTime, scale);
   }
@@ -588,7 +591,10 @@ static int validateAndParseDate(String columnName, Object input, long insertRowI
     if (offsetDateTime.getYear() < -9999 || offsetDateTime.getYear() > 9999) {
       throw new SFException(
           ErrorCode.INVALID_VALUE_ROW,
-          "Date out of representable inclusive range of years between -9999 and 9999");
+          String.format(
+              "Date out of representable inclusive range of years between -9999 and 9999, Row"
+                  + " Index:%d",
+              insertRowIndex));
     }
 
     return Math.toIntExact(offsetDateTime.toLocalDate().toEpochDay());
@@ -814,7 +820,7 @@ static void checkValueInRange(
       throw new SFException(
           ErrorCode.INVALID_FORMAT_ROW,
           String.format(
-              "Number out of representable exclusive range of (-1e%s..1e%s), Row Index:%s",
+              "Number out of representable exclusive range of (-1e%s..1e%s), Row Index:%d",
               precision - scale, precision - scale, insertRowIndex));
     }
   }
@@ -859,7 +865,7 @@ private static SFException typeNotAllowedException(
         ErrorCode.INVALID_FORMAT_ROW,
         String.format(
             "Object of type %s cannot be ingested into Snowflake column %s of type %s, Row"
-                + " Index:%s",
+                + " Index:%d",
             javaType.getName(), columnName, snowflakeType, insertRowIndex),
         String.format(
             String.format("Allowed Java types: %s", String.join(", ", allowedJavaTypes))));
@@ -882,7 +888,7 @@ private static SFException valueFormatNotAllowedException(
     return new SFException(
         ErrorCode.INVALID_VALUE_ROW,
         String.format(
-            "Value cannot be ingested into Snowflake column %s of type %s, Row Index: %s, reason:"
+            "Value cannot be ingested into Snowflake column %s of type %s, Row Index:%d, reason:"
                 + " %s",
             columnName, snowflakeType, rowIndex, reason));
   }

src/main/java/net/snowflake/ingest/streaming/internal/ParquetRowBuffer.java

@@ -210,8 +210,8 @@ private float addRow(
       throw new SFException(
           ErrorCode.MAX_ROW_SIZE_EXCEEDED,
           String.format(
-              "rowSizeInBytes=%.3f maxAllowedRowSizeInBytes=%d",
-              size, clientBufferParameters.getMaxAllowedRowSizeInBytes()));
+              "rowSizeInBytes=%.3f, maxAllowedRowSizeInBytes=%d, Row Index=%d",
+              size, clientBufferParameters.getMaxAllowedRowSizeInBytes(), insertRowsCurrIndex));
     }
 
     out.accept(Arrays.asList(indexedRow));

src/test/java/net/snowflake/ingest/streaming/internal/DataValidationUtilTest.java

@@ -676,19 +676,19 @@ public void testTooLargeMultiByteSemiStructuredValues() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type VARIANT, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type VARIANT, Row Index:0, reason:"
             + " Variant too long: length=18874376 maxLength=16777152",
         () -> validateAndParseVariant("COL", m, 0));
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type ARRAY, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type ARRAY, Row Index:0, reason:"
             + " Array too large. length=18874378 maxLength=16777152",
         () -> validateAndParseArray("COL", m, 0));
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type OBJECT, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type OBJECT, Row Index:0, reason:"
             + " Object too large. length=18874376 maxLength=16777152",
         () -> validateAndParseObject("COL", m, 0));
   }
@@ -1011,7 +1011,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type BOOLEAN, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type BOOLEAN, Row Index:0, reason:"
             + " Not a valid boolean, see"
             + " https://docs.snowflake.com/en/sql-reference/data-types-logical.html#conversion-to-boolean"
             + " for the list of supported formats",
@@ -1027,7 +1027,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type TIME, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type TIME, Row Index:0, reason:"
             + " Not a valid time, see"
             + " https://docs.snowflake.com/en/user-guide/data-load-snowpipe-streaming-overview for"
             + " the list of supported formats",
@@ -1043,7 +1043,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type DATE, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type DATE, Row Index:0, reason:"
             + " Not a valid value, see"
             + " https://docs.snowflake.com/en/user-guide/data-load-snowpipe-streaming-overview for"
             + " the list of supported formats",
@@ -1060,7 +1060,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index: 0,"
+            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index:0,"
             + " reason: Not a valid value, see"
             + " https://docs.snowflake.com/en/user-guide/data-load-snowpipe-streaming-overview for"
             + " the list of supported formats",
@@ -1077,7 +1077,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index: 0,"
+            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index:0,"
             + " reason: Not a valid value, see"
             + " https://docs.snowflake.com/en/user-guide/data-load-snowpipe-streaming-overview for"
             + " the list of supported formats",
@@ -1094,7 +1094,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index: 0,"
+            + " cannot be ingested into Snowflake column COL of type TIMESTAMP, Row Index:0,"
             + " reason: Not a valid value, see"
             + " https://docs.snowflake.com/en/user-guide/data-load-snowpipe-streaming-overview for"
             + " the list of supported formats",
@@ -1110,7 +1110,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type NUMBER, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type NUMBER, Row Index:0, reason:"
             + " Not a valid number",
         () -> validateAndParseBigDecimal("COL", "abc", 0));
 
@@ -1124,7 +1124,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type REAL, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type REAL, Row Index:0, reason:"
             + " Not a valid decimal number",
         () -> validateAndParseReal("COL", "abc", 0));
 
@@ -1138,7 +1138,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type STRING, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type STRING, Row Index:0, reason:"
             + " String too long: length=3 characters maxLength=2 characters",
         () -> validateAndParseString("COL", "abc", Optional.of(2), 0));
 
@@ -1152,13 +1152,13 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type BINARY, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type BINARY, Row Index:0, reason:"
             + " Binary too long: length=2 maxLength=1",
         () -> validateAndParseBinary("COL", new byte[] {1, 2}, Optional.of(1), 0));
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type BINARY, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type BINARY, Row Index:0, reason:"
             + " Not a valid hex string",
         () -> validateAndParseBinary("COL", "ghi", Optional.empty(), 0));
 
@@ -1173,7 +1173,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type VARIANT, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type VARIANT, Row Index:0, reason:"
             + " Not a valid JSON",
         () -> validateAndParseVariant("COL", "][", 0));
 
@@ -1188,7 +1188,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type ARRAY, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type ARRAY, Row Index:0, reason:"
             + " Not a valid JSON",
         () -> validateAndParseArray("COL", "][", 0));
 
@@ -1203,7 +1203,7 @@ public void testExceptionMessages() {
     expectErrorCodeAndMessage(
         ErrorCode.INVALID_VALUE_ROW,
         "The given row cannot be converted to the internal format due to invalid value: Value"
-            + " cannot be ingested into Snowflake column COL of type OBJECT, Row Index: 0, reason:"
+            + " cannot be ingested into Snowflake column COL of type OBJECT, Row Index:0, reason:"
             + " Not a valid JSON",
         () -> validateAndParseObject("COL", "}{", 0));
   }

src/test/java/net/snowflake/ingest/streaming/internal/RowBufferTest.java

@@ -308,7 +308,7 @@ public void testRowIndexWithMultipleRowsWithError() {
             .equalsIgnoreCase(
                 "The given row cannot be converted to the internal format due to invalid value:"
                     + " Value cannot be ingested into Snowflake column COLCHAR of type STRING, Row"
-                    + " Index: 1, reason: String too long: length=22 characters maxLength=11"
+                    + " Index:1, reason: String too long: length=22 characters maxLength=11"
                     + " characters"));
   }
 

src/test/java/net/snowflake/ingest/streaming/internal/SnowflakeStreamingIngestChannelTest.java

@@ -572,8 +572,8 @@ public void testInsertTooLargeRow() {
             .collect(Collectors.toList());
 
     String expectedMessage =
-        "The given row exceeds the maximum allowed row size rowSizeInBytes=67109128.000"
-            + " maxAllowedRowSizeInBytes=67108864";
+        "The given row exceeds the maximum allowed row size rowSizeInBytes=67109128.000,"
+            + " maxAllowedRowSizeInBytes=67108864, Row Index=0";
 
     Map<String, Object> row = new HashMap<>();
     schema.forEach(x -> row.put(x.getName(), byteArrayOneMb));