SNOW-918949: Add row index information to all exceptions #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdedb23.
…gest-java into tzhang-si-fixes
| @@ -210,8 +210,8 @@ private float addRow( | |||
| throw new SFException( | |||
There was a problem hiding this comment.
Alternatively, is it worth having a list of longs that we store in a SFException that can be accessed via something like getRowIndexes? This will reduce the need to parse an error message which is error prone.
There was a problem hiding this comment.
We already doing that with CONTINUE, this is for ABORT where we thrown an exception directly
sfc-gh-rcheng
approved these changes
Sep 21, 2023
sfc-gh-xhuang
approved these changes
Sep 26, 2023
+1 |
I updated everything to rowIndex, I think it's better than insertRowsCurrIndex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add row index information to all exceptions, also unify the format so it can be easily parsed