Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clientConfigFile to ConnectionOptions type #843

Merged
merged 1 commit into from
May 22, 2024

Conversation

ldaijiw
Copy link
Contributor

@ldaijiw ldaijiw commented May 22, 2024

Description

Please explain the changes you made here.
Adds clientConfigFile to ConnectionOptions type as per documented additional connection options

Closes #842

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@ldaijiw ldaijiw requested a review from a team as a code owner May 22, 2024 12:27
Copy link

github-actions bot commented May 22, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ldaijiw
Copy link
Contributor Author

ldaijiw commented May 22, 2024

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-pmotacki
Copy link
Collaborator

Thank you for your contribution @ldaijiw

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 06aad30 into snowflakedb:master May 22, 2024
46 of 49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@ldaijiw ldaijiw deleted the connection_options_type branch May 22, 2024 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1441259: Add clientConfigFile to ConnectionOptions type
2 participants