Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1441259: Add clientConfigFile to ConnectionOptions type #842

Closed
ldaijiw opened this issue May 22, 2024 · 1 comment · Fixed by #843
Closed

SNOW-1441259: Add clientConfigFile to ConnectionOptions type #842

ldaijiw opened this issue May 22, 2024 · 1 comment · Fixed by #843
Assignees
@sfc-gh-dszmolka
Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@ldaijiw
Copy link
Contributor

ldaijiw commented May 22, 2024 •
edited
Loading

What is the current behavior?

With typescript, When using createConnection or createPool and following the documentation for easy logging, adding the clientConfigFile connection parameter raises a type error.

Object literal may only specify known properties, and 'clientConfigFile' does not exist in type 'ConnectionOptions'.

What is the desired behavior?

As per the connection options documented, clientConfigFile should be added to the ConnectionOptions type so that it can be used in typescript

How would this improve snowflake-connector-nodejs?

Improved typing

References, Other Background

What is your Snowflake account identifier, if any?
@github-actions github-actions bot changed the title Add clientConfigFile to ConnectionOptions type SNOW-1441259: Add clientConfigFile to ConnectionOptions type May 22, 2024
@ldaijiw ldaijiw mentioned this issue May 22, 2024
Merged
5 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this May 22, 2024
@sfc-gh-dszmolka
Copy link
Collaborator

hi - apparently we indeed missed this; thank you for adding it in #843 and so quickly , literally hours after the typings were merged ;)

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team status-pr_pending_merge A PR is made and is under review labels May 22, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-pr_pending_merge A PR is made and is under review label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clientConfigFile to ConnectionOptions type ldaijiw/snowflake-connector-nodejs
2 participants
@ldaijiw @sfc-gh-dszmolka