Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Context Cache integration testing fix #647

Merged
merged 5 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions test/integration/testHTAP.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,50 +7,63 @@ const async = require('async');
const connOption = require('./connectionOptions').valid;
const testUtil = require('./testUtil');

function getRandomDBNames() {
sfc-gh-pmotacki marked this conversation as resolved.
Show resolved Hide resolved
const dbName = 'qcc_test_db';
const arr = [];
const randomNumber = Math.floor(Math.random() * 10000);
sfc-gh-dprzybysz marked this conversation as resolved.
Show resolved Hide resolved
for (let i = 0; i < 3; i++){
arr.push(dbName + (randomNumber + i));
}
return arr;
}

// Only the AWS servers support the hybrid table in the GitHub action.
if (process.env.CLOUD_PROVIDER === 'AWS') {
describe('Query Context Cache test', function () {
this.retries(3);
let connection;

before(async () => {
const dbNames = getRandomDBNames();

beforeEach(async () => {
connection = testUtil.createConnection(connOption);
await testUtil.connectAsync(connection);
});

after(async () => {
await testUtil.dropDBsIgnoringErrorsAsync(connection, dbNames);
await testUtil.destroyConnectionAsync(connection);
});

const querySet = [
{
sqlTexts: [
'create or replace database db1',
`create or replace database ${dbNames[0]}`,
'create or replace hybrid table t1 (a int primary key, b int)',
'insert into t1 values (1, 2), (2, 3), (3, 4)'
],
QccSize: 2,
},
{
sqlTexts: [
'create or replace database db2',
`create or replace database ${dbNames[1]}`,
'create or replace hybrid table t2 (a int primary key, b int)',
'insert into t2 values (1, 2), (2, 3), (3, 4)'
],
QccSize: 3,
},
{
sqlTexts: [
'create or replace database db3',
`create or replace database ${dbNames[2]}`,
'create or replace hybrid table t3 (a int primary key, b int)',
'insert into t3 values (1, 2), (2, 3), (3, 4)'
],
QccSize: 4,
},
{
sqlTexts: [
'select * from db1.public.t1 x, db2.public.t2 y, db3.public.t3 z where x.a = y.a and y.a = z.a;',
'select * from db1.public.t1 x, db2.public.t2 y where x.a = y.a;',
'select * from db2.public.t2 y, db3.public.t3 z where y.a = z.a;'
`select * from ${dbNames[0]}.public.t1 x, ${dbNames[1]}.public.t2 y, ${dbNames[2]}.public.t3 z where x.a = y.a and y.a = z.a;`,
`select * from ${dbNames[0]}.public.t1 x, ${dbNames[1]}.public.t2 y where x.a = y.a;`,
`select * from ${dbNames[1]}.public.t2 y, ${dbNames[2]}.public.t3 z where y.a = z.a;`
],
QccSize: 4,
},
Expand Down
16 changes: 16 additions & 0 deletions test/integration/testUtil.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,22 @@ module.exports.dropTablesIgnoringErrorsAsync = async (connection, tableNames) =>
}
};

/**
* Drop databases one by one if exist - any connection error is ignored
* @param connection Connection
* @param dbNames string[]
* @return {Promise<void>}
*/
module.exports.dropDBsIgnoringErrorsAsync = async (connection, dbNames) => {
for (const dbName of dbNames) {
try {
await executeCmdAsync(connection, `DROP DATABASE IF EXISTS ${dbName}`);
} catch (e) {
console.warn(`Cannot drop database ${dbName}: ${JSON.stringify(e)}`);
}
}
};

module.exports.checkError = function (err) {
assert.ok(!err, JSON.stringify(err));
};
Expand Down