Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Context Cache integration testing fix #647

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Query Context Cache integration testing fix #647

merged 5 commits into from
Sep 26, 2023

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

  • I modified the test to generate random DB names in the test.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review September 24, 2023 07:18
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner September 24, 2023 07:18
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Sep 25, 2023
View reviewed changes
test/integration/testUtil.js Outdated Show resolved Hide resolved
test/integration/testHTAP.js Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 8cd6371 into master Sep 26, 2023
30 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the qcctestingfix branch September 26, 2023 07:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-jy @sfc-gh-dprzybysz @sfc-gh-pmotacki