Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-968914 Break waiting on pool destroy #953

rename method

6d04f60
Select commit
Loading
Failed to load commit list.
Merged

SNOW-968914 Break waiting on pool destroy #953

rename method
6d04f60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2024 in 0s

85.43% (+0.12%) compared to 45b428f

View this Pull Request on Codecov

85.43% (+0.12%) compared to 45b428f

Details

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.43%. Comparing base (45b428f) to head (6d04f60).

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 90.62% 1 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/WaitingQueue.cs 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #953      +/-   ##
====================================================================
+ Coverage                             85.30%   85.43%   +0.12%     
====================================================================
  Files                                   106      106              
  Lines                                 10671    10742      +71     
  Branches                               1026     1027       +1     
====================================================================
+ Hits                                   9103     9177      +74     
+ Misses                                 1319     1317       -2     
+ Partials                                249      248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.