Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-968914 Break waiting on pool destroy #953

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-968914 Break waiting on pool destroy

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner May 20, 2024 15:03
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.43%. Comparing base (45b428f) to head (6d04f60).

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 90.62% 1 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/WaitingQueue.cs 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #953      +/-   ##
====================================================================
+ Coverage                             85.30%   85.43%   +0.12%     
====================================================================
  Files                                   106      106              
  Lines                                 10671    10742      +71     
  Branches                               1026     1027       +1     
====================================================================
+ Hits                                   9103     9177      +74     
+ Misses                                 1319     1317       -2     
+ Partials                                249      248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit b6e598f into pool/SNOW-860872-connection-pool May 21, 2024
23 of 24 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-968914_security_mitigations_dispose branch May 21, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants