Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-944715 Validate account domain #820

Merged
merged 2 commits into from
Dec 1, 2023

added test for empty account

685f87f
Select commit
Loading
Failed to load commit list.
Merged

SNOW-944715 Validate account domain #820

added test for empty account
685f87f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 1, 2023 in 0s

83.48% (-0.08%) compared to 62f2206

View this Pull Request on Codecov

83.48% (-0.08%) compared to 62f2206

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (62f2206) 83.56% compared to head (685f87f) 83.48%.
Report is 2 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSessionProperty.cs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   83.56%   83.48%   -0.08%     
==========================================
  Files          89       89              
  Lines        9155     9188      +33     
  Branches      837      841       +4     
==========================================
+ Hits         7650     7671      +21     
- Misses       1275     1285      +10     
- Partials      230      232       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.