Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-944715 Validate account domain #820

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Validate account domain to prevent SSRF.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner November 23, 2023 16:53
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-944715_account_name_validation branch 2 times, most recently from 4cf505d to 40561d2 Compare November 23, 2023 17:01
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-944715_account_name_validation branch from 40561d2 to a6a0ee4 Compare November 23, 2023 17:03
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (62f2206) 83.56% compared to head (685f87f) 83.48%.
Report is 2 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSessionProperty.cs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   83.56%   83.48%   -0.08%     
==========================================
  Files          89       89              
  Lines        9155     9188      +33     
  Branches      837      841       +4     
==========================================
+ Hits         7650     7671      +21     
- Misses       1275     1285      +10     
- Partials      230      232       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-944715_account_name_validation branch from 63b6928 to 685f87f Compare December 1, 2023 11:33
@sfc-gh-knozderko sfc-gh-knozderko merged commit ecdefc6 into master Dec 1, 2023
21 of 22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-944715_account_name_validation branch December 1, 2023 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants