Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1640968 dispose disposable objects #1014
SNOW-1640968 dispose disposable objects #1014
Changes from 4 commits
6212da4
c1eb279
d108ac2
a8f9d7e
27d63df
4e35ac9
8527933
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, AWS)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, AZURE)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, GCP)
Check warning on line 74 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net6.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net7.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on MAC (net8.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net6.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net7.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Linux (net8.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net8.0, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net472, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net48, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net462, AWS)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net7.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net6.0, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, AZURE)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net481, GCP)
Check warning on line 125 in Snowflake.Data.Tests/UnitTests/SFRemoteStorageClientTest.cs
GitHub Actions / Tests on Windows (net471, GCP)
Check warning on line 103 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L103
Check warning on line 105 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L105
Check warning on line 108 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L108
Check warning on line 113 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L110-L113
Check warning on line 115 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L115
Check warning on line 120 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L117-L120
Check warning on line 124 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L123-L124
Check warning on line 204 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L204
Check warning on line 208 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L206-L208
Check warning on line 212 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L211-L212
Check warning on line 214 in Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs
Codecov / codecov/patch
Snowflake.Data/Core/Authenticator/KeyPairAuthenticator.cs#L214