Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1640968 dispose disposable objects #1014

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Aug 30, 2024

Description

SNOW-1640968 dispose disposable objects

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner August 30, 2024 14:23
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 78.23129% with 32 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (8a22adb) to head (8527933).

Files with missing lines Patch % Lines
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 0.00% 24 Missing ⚠️
Snowflake.Data/Core/SFBindUploader.cs 82.35% 6 Missing ⚠️
Snowflake.Data/Core/FileTransfer/StreamPair.cs 83.33% 0 Missing and 1 partial ⚠️
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   85.68%   85.59%   -0.10%     
==========================================
  Files         106      106              
  Lines       10796    10801       +5     
  Branches     1035     1035              
==========================================
- Hits         9251     9245       -6     
- Misses       1295     1306      +11     
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth checking if
public CryptoStream (System.IO.Stream stream, System.Security.Cryptography.ICryptoTransform transform, System.Security.Cryptography.CryptoStreamMode mode);
is available on our all supported .net environemnts to avoid StreamPair class.
LGTM otherwise

@sfc-gh-knozderko sfc-gh-knozderko merged commit f178614 into master Sep 3, 2024
52 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1640968_dispose_disposable_objects branch September 3, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants