Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1640968 dispose disposable objects #1014

Merged
merged 7 commits into from
Sep 3, 2024

Merge branch 'master' into SNOW-1640968_dispose_disposable_objects

8527933
Select commit
Loading
Failed to load commit list.
Merged

SNOW-1640968 dispose disposable objects #1014

Merge branch 'master' into SNOW-1640968_dispose_disposable_objects
8527933
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 3, 2024 in 0s

85.59% (-0.10%) compared to 8a22adb

View this Pull Request on Codecov

85.59% (-0.10%) compared to 8a22adb

Details

Codecov Report

Attention: Patch coverage is 78.23129% with 32 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (8a22adb) to head (8527933).

Files with missing lines Patch % Lines
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 0.00% 24 Missing ⚠️
Snowflake.Data/Core/SFBindUploader.cs 82.35% 6 Missing ⚠️
Snowflake.Data/Core/FileTransfer/StreamPair.cs 83.33% 0 Missing and 1 partial ⚠️
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   85.68%   85.59%   -0.10%     
==========================================
  Files         106      106              
  Lines       10796    10801       +5     
  Branches     1035     1035              
==========================================
- Hits         9251     9245       -6     
- Misses       1295     1306      +11     
  Partials      250      250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov