-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1640968 dispose disposable objects #1014
SNOW-1640968 dispose disposable objects #1014
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
- Coverage 85.68% 85.59% -0.10%
==========================================
Files 106 106
Lines 10796 10801 +5
Branches 1035 1035
==========================================
- Hits 9251 9245 -6
- Misses 1295 1306 +11
Partials 250 250 ☔ View full report in Codecov by Sentry. |
Snowflake.Data/Core/FileTransfer/StorageClient/SFLocalStorageUtil.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth checking if
public CryptoStream (System.IO.Stream stream, System.Security.Cryptography.ICryptoTransform transform, System.Security.Cryptography.CryptoStreamMode mode);
is available on our all supported .net environemnts to avoid StreamPair class.
LGTM otherwise
Description
SNOW-1640968 dispose disposable objects
Checklist
dotnet test
)