perf: improve spia script and report #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re merely subsets of the main table without any further value added (contrary to previous variable naming, no sorting or anything happened in the creation of these tables)
johanneskoester
approved these changes
Jan 31, 2024
johanneskoester
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [2.5.4](v2.5.3...v2.5.4) (2024-01-31) ### Performance Improvements * improve spia script and report ([#83](#83)) ([4b3cc16](4b3cc16)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes come from implementing spia in a GFOLD-based workflow here:
https://github.com/dlaehnemann/rna-seq-conservative-fold-change-without-replicates
This was modeled on the spia implementation here, and led to some cleanup of the
spia.Rscript, to the removal of unnecessary report tables that didn't add any value and to some improvements of the spia reporting table.