Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update refs for files which aren't renamed (issue #131) #132

Merged
merged 1 commit into from
Mar 3, 2016

Conversation

inian
Copy link
Contributor

@inian inian commented Jan 31, 2016

No description provided.

smysnk pushed a commit that referenced this pull request Mar 3, 2016
Don't update refs for files which aren't renamed (issue #131)
@smysnk smysnk merged commit cb0b0e3 into smysnk:master Mar 3, 2016
@smysnk
Copy link
Owner

smysnk commented Mar 3, 2016

Looks good, thanks!

@prannayb
Copy link

prannayb commented Mar 4, 2016

I have a problem with this change. Even though I'm not renaming a particular file, I do want to update it's reference. Since I'm using this for appCache generation, for files that are served though an API and are not static files, I cannot rename their source files. However, based on their source files I can supply different query params for cache busting. This was previously done by supplying the source file name pattern in dontRenameFiles, and then in the replacer for file types of compiled files, I replace their references from
"Controller/Foo?page=welcome"
to
"Controller/Foo?hash=a654de7e&page=welcome?

As a workaround I'm having to supply a transformFilename function, which implements the dontRenameFile regEx exclusion.

smysnk pushed a commit that referenced this pull request Mar 4, 2016
@kapiwko
Copy link

kapiwko commented Jul 18, 2016

Why is that reverted? May create another option for case above?

@peterlozano
Copy link

I posted a new fix on #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants