Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files under dontRenameFile should not have their references updated #131

Open
inian opened this issue Jan 31, 2016 · 3 comments
Open

files under dontRenameFile should not have their references updated #131

inian opened this issue Jan 31, 2016 · 3 comments

Comments

@inian
Copy link
Contributor

inian commented Jan 31, 2016

If I have a file under dontRenameFile, then it's reference should not be updated too.

I can't think of a case where the user does not generate revisions for a file but wants to rename them! (The file would not exist in the first place!)

@inian
Copy link
Contributor Author

inian commented Jan 31, 2016

Sent a PR #132 for this

@mix3d
Copy link

mix3d commented Mar 3, 2016

Been having this problem. Will check out your commit!


Fixes the problems I've encountered. Beautiful!

Can we get this merged?!

smysnk pushed a commit that referenced this issue Mar 3, 2016
Don't update refs for files which aren't renamed (issue #131)
@prannayb
Copy link

prannayb commented Mar 4, 2016

I have a problem with this change. Even though I'm not renaming a particular file, I do want to update it's reference. Since I'm using this for appCache generation, for files that are served though an API and are not static files, I cannot rename their source files. However, based on their source files I can supply different query params for cache busting. This was previously done by supplying the source file name pattern in dontRenameFiles, and then in the replacer for file types of compiled files, I replace their references from
"Controller/Foo?page=welcome"
to
"Controller/Foo?hash=a654de7e&page=welcome?

As a workaround I'm having to supply a transformFilename function, which implements the dontRenameFile regEx exclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants