-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files under dontRenameFile should not have their references updated #131
Comments
Sent a PR #132 for this |
Been having this problem. Will check out your commit! Fixes the problems I've encountered. Beautiful! Can we get this merged?! |
Don't update refs for files which aren't renamed (issue #131)
I have a problem with this change. Even though I'm not renaming a particular file, I do want to update it's reference. Since I'm using this for appCache generation, for files that are served though an API and are not static files, I cannot rename their source files. However, based on their source files I can supply different query params for cache busting. This was previously done by supplying the source file name pattern in dontRenameFiles, and then in the replacer for file types of compiled files, I replace their references from As a workaround I'm having to supply a transformFilename function, which implements the dontRenameFile regEx exclusion. |
If I have a file under dontRenameFile, then it's reference should not be updated too.
I can't think of a case where the user does not generate revisions for a file but wants to rename them! (The file would not exist in the first place!)
The text was updated successfully, but these errors were encountered: